-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CLIENT-3027] CI/CD: Use Dockerfile to build Docker image for Aerospike enterprise server with security enabled #645
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #645 +/- ##
=======================================
Coverage 81.33% 81.33%
=======================================
Files 100 100
Lines 15341 15341
=======================================
Hits 12477 12477
Misses 2864 2864 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One change request to get the hard coded credentials stored in a github secret
if [[ $is_security_enabled == true ]]; then | ||
# We need to pass credentials to asinfo if server requires it | ||
# TODO: passing in hardcoded credentials since I can't figure out how to use --instance with global astools.conf | ||
user_credentials="--user=admin --password=admin" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
store the user and password credentials in a github secret
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the default credentials for the Aerospike EE server with security enabled. I don't think using secrets here is necessary unless we change those credentials
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes look good. we can fix the login issue when we move to pub
Extra changes:
Workflow regression testing
Build wheels (including macOS x86 testing):
With latest tag by default: https://github.com/aerospike/aerospike-client-python/actions/runs/9959790445/job/27517447730
With custom server tag: https://github.com/aerospike/aerospike-client-python/actions/runs/9960467374
Stage tests (all tests pass except for noise): https://github.com/aerospike/aerospike-client-python/actions/runs/9960475436
Valgrind: https://github.com/aerospike/aerospike-client-python/actions/runs/9960475827
Dev workflow part 1: https://github.com/aerospike/aerospike-client-python/actions/runs/9960479630